Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @soroban-react/contracts library #79

Merged

Conversation

esteblock
Copy link
Contributor

Move useContractValue and useSendTransaction functions to @soroban-react/contracts library
This will make soroban's dapps development easier.

Now supporting useContractValue function

Copy link
Contributor

@paulbellamy paulbellamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. I added a few code styling fixups. I like the more explicit named parameters to useContractValue. More extensible, and clearer what you're doing.

I opened paltalabs/soroban-react#5. With that, I think we can remove all the places we pass sorobanContext to useContractValue, and let it use the default. That should make useContractValue easier to use for users as well.

@esteblock
Copy link
Contributor Author

@paulbellamy
I added #80 changes into @soroban-react/contracts library in paltalabs/soroban-react#16
Then manually merged #80 with #79.
Also tried. Works ok :)

It's just failing in Rust / build-and-test (ubuntu-latest, x86_64-unknown-linux-gnu, true) (pull_request)
But it's the same error #80 has.

@paulbellamy
Copy link
Contributor

Looks great, thanks so much!

@paulbellamy paulbellamy merged commit 3ab575f into stellar:main Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants