Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: convert bindings to subcommands and add a ts one #644

Merged
merged 34 commits into from
Jun 13, 2023
Merged

feat!: convert bindings to subcommands and add a ts one #644

merged 34 commits into from
Jun 13, 2023

Conversation

willemneal
Copy link
Member

@willemneal willemneal commented May 18, 2023 •
edited
Loading

What

Refactor the bindings command into subcommands and adds a TS project.

Why

This way they can each have their own options.

Known limitations

Requires: stellar/rs-soroban-sdk#871

paulbellamy
paulbellamy reviewed May 22, 2023
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
cmd/soroban-cli/src/commands/contract/bindings/ts.rs Outdated Show resolved Hide resolved
@willemneal willemneal marked this pull request as ready for review June 1, 2023 15:36
paulbellamy
paulbellamy reviewed Jun 5, 2023
View reviewed changes
Copy link
Contributor

@paulbellamy paulbellamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a naming suggestion, but overall I think this is ready to go.
I'd like to get the sdk stuff merged/released first, then we can use that and merge this.

cmd/soroban-cli/src/commands/contract/bindings.rs Outdated Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
@chadoh chadoh mentioned this pull request Jun 8, 2023
Merged
@Shaptic Shaptic mentioned this pull request Jun 8, 2023
Closed
4 tasks
@paulbellamy paulbellamy merged commit dc7f5b8 into stellar:main Jun 13, 2023
20 checks passed
@tsachiherman tsachiherman mentioned this pull request Jun 13, 2023
Closed
@tsachiherman tsachiherman linked an issue Jun 13, 2023 that may be closed by this pull request
soroban-cli: add generative typescript support #681
Closed
@tsachiherman tsachiherman mentioned this pull request Jun 13, 2023
Closed
@mollykarcher mollykarcher added this to the Testnet Release milestone Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadoh chadoh chadoh left review comments

@paulbellamy paulbellamy paulbellamy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Soroban Testnet Release
Development

Successfully merging this pull request may close these issues.

soroban-cli: add generative typescript support
5 participants
@willemneal @chadoh @paulbellamy @mollykarcher @tsachiherman