Windows: fix race condition that causes spurious failures while adopting buckets #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How fun. |
|
r+ 484eee7 |
this removes risk of having files in use by child processes
MonsieurNicolas
force-pushed
the
windowsFixes
branch
from
484eee7
to
13e9306
Compare
|
didn't see the first |
|
r+ 13e9306 |
latobarita
added a commit
that referenced
this pull request
Mar 1, 2019
Windows: fix race condition that causes spurious failures while adopting buckets Reviewed-by: MonsieurNicolas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a race condition where file descriptors are inherited by child processes (such as "gzip"), which causes some operations, such as renaming buckets to fail with a "file in use" error.
The fix here is to move to Windows 7+ APIs, that allow to whitelist which descriptors to pass to the child process, in our case we only need the descriptor for standard output.