Windows: compile and stability fixes #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous fix for this 13e9306 missed that we should also disable global inheritance (and only use the white list)
|
r+ 2aac760 |
latobarita
added a commit
that referenced
this pull request
Aug 28, 2019
Windows: compile and stability fixes Reviewed-by: marta-lokhova
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses a few Windows issues (does not effect other platforms).
CreateProcessto inherit handles. This solves a race condition where core was not able to adopt buckets reliably since 2015.Error code 32instead ofThe process cannot access the file because it is being used by another process.