Windows handle fix part 3 #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r code also format error code in hex as this is how they're documented
|
r+ dffc866 |
|
@latobarita: retry |
|
(travis timed out talking to ubuntu servers) |
latobarita
added a commit
that referenced
this pull request
Sep 10, 2019
Windows handle fix part 3 Reviewed-by: graydon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the latest attempt at fixing a race condition when spawning processes in Windows.
Previous attempts were #2253 and #1987
Third time should do it:
using
PROC_THREAD_ATTRIBUTE_HANDLE_LISTrequires to setbInheritHandles =TRUEinCreateProcess(so #2253 was wrong, and the pieces that were working were by pure luck)https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-updateprocthreadattribute
the problem was actually that #1987 didn't set
PROC_THREAD_ATTRIBUTE_HANDLE_LISTwhen redirectingstdout, this was causing all inheritable handles to be inherited.