[PARTNER-71] Deprecate wallet_name #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Seems reasonable. One small fix. One suggested change.
Thanks for updating the changelog and meta.
Defer to @JakeUrban.
JakeUrban
approved these changes
Jul 12, 2023
pull bot
pushed a commit
to mikeyhodl/stellar-protocol
that referenced
this pull request
Jul 13, 2023
* Deprecate wallet_name * Update PR number * Add description of how to get wallet data * backspace * Fix description --------- Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Today, wallets can optionally provide name and url in the /interactive URLs. However, this information should be already known to the anchor, as the anchor knows the SEP-10 JWT auth token.
Proposal
wallet_nameandwallet_urlparameters become deprecated. Instead, anchors could use one of:client_domainfor non-custodial walletssubvalue of the auth JWT token for custodial walletsBackwards compatibility
This change is fully compatible.