Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update SEP-0011 to reflect new canonical asset format. #313

Merged
merged 2 commits into from
May 28, 2019

Conversation

stanford-scs
Copy link
Contributor

No description provided.

@theaeolianmachine theaeolianmachine merged commit 8a79008 into stellar:master May 28, 2019
@theaeolianmachine theaeolianmachine added the update Represents an update to an existing CAP/SEP. label May 30, 2019
@bartekn
Copy link
Contributor

bartekn commented Sep 18, 2019

The part of the doc changed in this PR was referenced in stellar/go#1754 because it's using asset format.

I don't think below is true:

Codes in Asset and AllowTrustOp should escape \, : and any byte outside the range 0x21-0x7e, but no other bytes. Trailing \x00 should not be shown except as needed to show an asset of type ASSET_TYPE_CREDIT_ALPHANUM12 fewer than 5 non-zero bytes.

in the context of stellar-core code. The relevant code is here and it looks like asset code must pass isalnum function so only alphanumeric characters can form a valid asset code.

@MonsieurNicolas
Copy link
Contributor

@bartekn is correct: I don't know where this comes from. Both the code and documentation are basically describing alphanum (with zero bytes only allowed as padding characters at the end of the asset code)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update Represents an update to an existing CAP/SEP.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants