Fixes for 0.6.0 #106
Fixes for 0.6.0 #106
Conversation
| @@ -177,7 +177,7 @@ export class Layer extends Component { | |||
| if (relationshipLabel != null && relationshipLabel.length > 0) { | |||
| let sub_q = "(false"; | |||
| relationshipLabel.forEach((value) => { | |||
| sub_q += ` OR r:\`${value.label}\``; | |||
| sub_q += ` OR type(r) = '${value.label}' `; | |||
There was a problem hiding this comment.
i tested it and it was working for me 🤔
maybe it depends on cypher/neo4j version, i'll double check this
There was a problem hiding this comment.
I was surprised too because it seemed to me I had already tested it, but tested in a Cypher shell and raises the same error. Documentation here: https://neo4j.com/docs/cypher-manual/4.3/clauses/where/#filter-on-relationship-type, only mention the "type(r)" method, so I think it is safer to go this way.
| @@ -210,7 +210,7 @@ export const Map = React.memo(({ layers, sideBarCollapsed }) => { | |||
| break; | |||
| } | |||
|
|
|||
| layerControl.addOverlay(newMapOverlays[ukey], ukey); | |||
| layerControl.addOverlay(newMapOverlays[ukey], name); | |||
There was a problem hiding this comment.
i'm still showing name to user 🤔 ah, i got what names you're talking about
changed this intentionally because having multiple layers with the same name (e.g. "New Layer") was leading to issues with layers deletion/updates. if i remember correctly the last created layer was getting deleted instead of the one i wanted to delete
There was a problem hiding this comment.
Ok I see, I'll experiment layer deletion, I think we can remove a layer without using its name (?), otherwise I'll rollback this update.
Small fixes after manual tests:
TODO: fix couple more issues (I, @nikita03565 , will handle this):
Prepare for 0.6.0 release: