Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync doesn't remove remotely deleted collections and articles #15

Closed
mergen3107 opened this issue Jun 16, 2024 · 3 comments
Closed

Sync doesn't remove remotely deleted collections and articles #15

mergen3107 opened this issue Jun 16, 2024 · 3 comments

Comments

@mergen3107
Copy link

Hi @stelzch
Here is another bug.

  1. I created test collections with names 1, 2, 3. Synced with Zotero - all good.
  2. Then deleted them on Zotero remotely via PC app.
  3. Synced again - deleted collections are still there.

So, sync can track existing colections', for example I had no issue when renaming them - no duplicates were created. However, it doesn't delete locally what was deleted remotely.

Thanks!

@mergen3107 mergen3107 changed the title Sync doesn't remove remotely deleted collections Sync doesn't remove remotely deleted collections and articles Jun 21, 2024
@mergen3107
Copy link
Author

Zotero just keeps adding items to after syncing, it doesn't check/track whether collections or articles have been deleted on the server.

@stelzch
Copy link
Owner

stelzch commented Oct 2, 2024

Deletion should work now, looking forward to bug reports.

For now the plugin does not delete attached files, as it could cause data loss: imagine a user making annotations into a pdf that then gets deleted during sync without warning.
We might want to add an option to prune attachments that are no longer in the database from storage.

@stelzch stelzch closed this as completed Oct 2, 2024
@mergen3107
Copy link
Author

Good point! Let me try it out.

Thank you very much for maintaining the plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants