Add utility functions and person parser #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 92.33% 92.65% +0.32%
==========================================
Files 21 23 +2
Lines 1917 2029 +112
Branches 490 519 +29
==========================================
+ Hits 1770 1880 +110
- Misses 141 143 +2
Partials 6 6
Continue to review full report at Codecov.
|
alex-ketch
approved these changes
May 17, 2019
There was a problem hiding this comment.
Merging as it looks good overall, but I will be breaking out some of the concerns raised here into their own issues.
Thanks for this work @nokome! I agree that this separation of concerns between Schema/Convert makes much better sense 👍
This was referenced May 17, 2019
Closed
|
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the sister PR to stencila/schema#65. It adds functions such as
validateandcoercewhich are (will be) used here to ensure that data that is decoded from other formats conforms to the schema.