Pull eLife job #436
Merged
Pull eLife job #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nokome
requested changes
May 13, 2020
There was a problem hiding this comment.
Thanks @richardmansfield. Could you make the requested change re the BROKER_URL. The other one re use of a temp file is just a suggestion.
6 tasks
See https://www.flake8rules.com/rules/W504.html. W503 and W504 are contradictory; we should only enforce the one which black cares about.
|
🎉 This PR is included in version 2.23.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just exercising the pull request workflow, the pull job is still completely untested from the director side.