Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Meson port with layer-shell support #4

Merged
merged 1 commit into from
May 21, 2024

Conversation

dimkr
Copy link
Contributor

@dimkr dimkr commented May 17, 2024

This is pretty much a 1:1 port of layer-shell support in https://github.com/puppylinux-woof-CE/gtkdialog (mostly @01micko's work) to yad.

Supporting the layer-shell protocol makes it possible to use yad for things like splash screens, notifications, panels and all kinds of floating widgets, when running under a wlroots-based compositor. The first use case I see is replacing yaf-splash and gtkdialog-splash with something simpler that uses yad under the hood, because yad is more maintainable and more likely to be ported to GTK+ 4 and beyond.

To make life easier and maintain backward compatibility, this PR adds basic Meson build system support (without optional features like the icon browser) that builds the GTK+ 3 variant and auto-enables layer-shell support if possible.

@step-
Copy link
Owner

step- commented May 20, 2024

Thank you Dima, it looks good. Could you please possibly replace strcmp with strcasecmp for uniformity with other option setting code in the file, and also add a space between function names and the opening bracket? I would do it myself but then I'm not sure if GH would give you attribution for this PR.

@dimkr
Copy link
Contributor Author

dimkr commented May 21, 2024

replace strcmp with strcasecmp

Done

add a space between function names and the opening bracket

Done

@step- step- merged commit 0c8e491 into step-:maintain-gtk2 May 21, 2024
@step-
Copy link
Owner

step- commented May 21, 2024

Thank you again!

@dimkr
Copy link
Contributor Author

dimkr commented May 21, 2024

Thank you @step-! I didn't expect this level of cooperation and already accepted the fate of patching my distro's yad forever. Maybe there will be more to come, once I finish porting all gtkdialog-based stuff to yad and find more use cases yad doesn't address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants