Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces the scopes of the manifest.json file and does a dark mode check on initialization #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

helfrichmichael
Copy link

Here's a possible solution to reducing the scope of the manifest.json file for the Thingiverse Downloader. My approach was to develop a helper HTML and JS file to check for the dark mode theme being enabled/disabled. It then forwards that as a runtime message to the background service worker and that will then adjust the constant/icon.

Let me know what you think about this approach, but hoping it helps (used to TypeScript mostly these days, so was trying to solve this without introducing more packages/dependencies).

…ialization of the Chrome Extension.

The runtime for this could also be adjusted to other approaches, but I don't anticipate people changing this often (a restart would also resolve this).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant