Reduces the scopes of the manifest.json file and does a dark mode check on initialization #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a possible solution to reducing the scope of the manifest.json file for the Thingiverse Downloader. My approach was to develop a helper HTML and JS file to check for the dark mode theme being enabled/disabled. It then forwards that as a runtime message to the background service worker and that will then adjust the constant/icon.
Let me know what you think about this approach, but hoping it helps (used to TypeScript mostly these days, so was trying to solve this without introducing more packages/dependencies).