New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LinearHolonomicTask #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this improvement! The PR is starting to look good. I just have one technical point re. the computation of the error in the base LinearHolonomicTask
.
Would you be up for adding unit tests for the new tasks in the You could take inspiration from |
Yes, I can make those unit tests. |
…responding unit tests
Based on your comments above, I've made some changes and added unit tests. Please feel free to give me any feedback you might have. |
LGTM. I took care of the documentation, fixed the issue |
I closed the old PR and instead made cleaner commit history.
Here, the major changes are the following:
I am looking forward to seeing any feedback from you.
Thank you!