-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary RPC REPE #577
base: main
Are you sure you want to change the base?
Binary RPC REPE #577
Conversation
@jbbjarnason, I added a unit test that doesn't build yet, but I'll keep adding to it to describe the kind of interface we want. I'm thinking of adding custom data as a The message itself is still templated on the body, so you can decode/encode straight to memory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good
struct header final | ||
{ | ||
uint8_t version = 0b00000'110; // the REPE version | ||
bool error = false; // whether an error has occurred |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the error
be something else than bool?
How does this member relate to the error
struct below
|
||
params = {}; | ||
msg.header = {}; | ||
expect(!glz::read_binary(msg, buffer)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can read_binary return an error with partial
as an error code? In terms of networking, so we would know to async_receive
more data into the buffer before trying again.
Secondly would it be beneficial to be able to only read the header?
glz::repe::header header{};
glz::read_binary(header, buffer);
This is implementation of the new REPE binary RPC specification using BEVE