New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document for ts_proto_opt is wrong #34

Closed

rory-ye-nv opened this issue Mar 5, 2020 · 2 comments

rory-ye-nv commented Mar 5, 2020 •

edited

should be --ts_opt=xxx and --ts_out=xxx, don't know why all the document is provide the wrong config options.

The text was updated successfully, but these errors were encountered:

Author

rory-ye-nv commented Mar 5, 2020

got it. the prefix is follow the plugin name.

and I use

protoc --plugin="protoc-gen-ts=${SCRIPT_DIR}/../node_modules/.bin/protoc-gen-ts_proto" \
  --ts_out="${OUT_DIR}" \
  --ts_opt=outputEncodeMethods=false,outputClientImpl=false \
  --proto_path=xxx

rory-ye-nv closed this as completed

Owner

stephenh commented Mar 5, 2020

Yeah, that was not intuitive to me either at first. I'll make a note of that in the docs. Thanks!

zfy0701 added a commit to sentioxyz/ts-proto that referenced this issue


          refactor: use yarn ws to reorg, adjust codegen path (stephenh#34)

fecde7a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment