fix: outputSchema=true when onlyTypes=true
#1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @lukealvoeiro ! Definitely appreciate the todo/test coverage to at least document behavior. Looks like the build is failing, but is it fall just version bumps of protoc? Lol, that would be unfortunate 🤔 . Wonder how we can handle that cleanly... Might have to make that output optional, if even just for our test suite? |
### Description - Add the `annotateFilesWithVersion` option so that changes are correctly captured in CI (eliminating noise on each file) - Added this option to the README
# [1.175.0](v1.174.0...v1.175.0) (2024-05-13) ### Features * optionally output versions used to generate files ([#1040](#1040)) ([53d6799](53d6799))
* main: chore(release): 1.175.0 [skip ci] feat: optionally output versions used to generate files (#1040)
|
@stephenh This should be all good to merge! |
stephenh
pushed a commit
that referenced
this pull request
May 15, 2024
## [1.175.1](v1.175.0...v1.175.1) (2024-05-15) ### Bug Fixes * `outputSchema=true` when `onlyTypes=true` ([#1039](#1039)) ([064665f](064665f))
|
🎉 This PR is included in version 1.175.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a conflict that is created between two options that results in code that fails to compile. Please note that this is not an attempt to fix the underlying problem, which I have explained in a TODO comment in the code for posterity. I also created new tests to capture any regressions.