steroids/dev#578 Сделать логику сохранения элементов дерево в local storage #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fogarea
reviewed
Jan 12, 2024
fogarea
approved these changes
Jan 16, 2024
src/hooks/useTree.ts
Outdated
| saveInClientStorage(); | ||
| }); | ||
|
|
||
| window.addEventListener('beforeunload', saveInClientStorage); |
There was a problem hiding this comment.
- Зачем эта строчка?
- Обращение к window, document всегда должно быть в хуке, а не просто в компоненте
- Нельзя просто так обращаться к window, document, потому что их нет в ssr режиме
There was a problem hiding this comment.
В момент перезагрузки страницы, данные не записывались в localstorage.
Переделал, добавил хук useBeforeUnload с его помощью сохраняет в localstorage.
Если такой вариант не подойдет, предлагаю созвониться
There was a problem hiding this comment.
Хорошо, такое решение подойдет. Но нужно проверить его в режиме SSR. Попробуй запустить сайт стероидов локально командой yarn ssr, если все корректно отработает, то можешь мержить этот pr
Daria-Kuzminykh
approved these changes
Feb 1, 2024
fogarea
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.