-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand the view of the source when reviewing violations #27
Comments
I wonder if we could put a PR into Path::Tiny to extend the lines, to have a start_at option.
Other wise we'll just have to make out own file splice subroutine. |
Or thinking about it, File::Tie could be an option. |
Actually I was thinking I could use the PPI nodes to get the info. Traverse up to the parent node, note the line number, render the parent node and trim the resulting string appropriately. That said, I've not tried to do this yet :)
|
I look forward to seeing that commit chain. On 5 Sep 2016 8:35 a.m., "Stevan Little" notifications@github.com wrote:
|
Haha, me too ;) |
As discussed in #22 we should show +/- 5 lines of source around the actual violation when reviewing them. Maybe even make the number of +/- lines a configuration variable.
The text was updated successfully, but these errors were encountered: