Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: 51a0794 do not respect aerial position #369

Closed
Zeioth opened this issue May 1, 2024 · 3 comments
Closed

bug: 51a0794 do not respect aerial position #369

Zeioth opened this issue May 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Zeioth
Copy link

Zeioth commented May 1, 2024

Neovim version (nvim -v)

NVIM v0.9.5 Release

Operating system/version

arch

Output of :AerialInfo

Aerial Info                                                                                                                                                                  
-----------                                                                                                                                                                  
Filetype: neo-tree                                                                                                                                                           
Configured backends:                                                                                                                                                         
  lsp (not supported) [No LSP client found that supports symbols]                                                                                                            
  treesitter (not supported) [No treesitter parser for neo-tree]                                                                                                             
  markdown (not supported) [Filetype is not markdown]                                                                                                                        
  man (not supported) [Filetype is not man]                                                                                                                                  
Show symbols: Constructor, Enum, Function, Interface, Method     

Describe the bug

See post below

What is the severity of this bug?

minor (annoyance)

Steps To Reproduce

  • Run :Neotree
  • Run :AerialOpen

Expected Behavior

  • Opening aerial while the cursor is over NeoTree should open Aerial in the correct position.
  • Ideally, with the content of the last valid targeted buffer.

More info

Relevant commit
51a0794

@Zeioth Zeioth added the bug Something isn't working label May 1, 2024
@Zeioth
Copy link
Author

Zeioth commented May 1, 2024

Opening aerial while the cursor is over NeoTree, open aerial in the wrong position.

screenshot_2024-05-01_18-20-08_987306721

If I open it while the cursor is over the buffer, it opens on the right position (on the right)
screenshot_2024-05-01_18-20-15_002572586

@Zeioth Zeioth changed the title bug: 51a07949abf169b4cad30e14c165ac1ec0ce4e6f do not respect aerial position bug: 51a07949abf169b4cad30e14c165ac1ec0ce4e6f do not respect aerial position May 1, 2024
@Zeioth Zeioth changed the title bug: 51a07949abf169b4cad30e14c165ac1ec0ce4e6f do not respect aerial position bug: 51a0794 do not respect aerial position May 1, 2024
@Zeioth Zeioth changed the title bug: 51a0794 do not respect aerial position bug: 51a0794 do not respect aerial position May 1, 2024
@Zeioth
Copy link
Author

Zeioth commented May 1, 2024

If you have no time to look into this, reverting the commit would be enough to at least prevent users from breaking the UI.

The mentioned commit seems to break ignore = {} too

Zeioth added a commit to Zeioth/aerial.nvim that referenced this issue May 1, 2024
Zeioth added a commit to Zeioth/aerial.nvim that referenced this issue May 1, 2024
stevearc added a commit that referenced this issue May 8, 2024
There was an edge case with "ignored" window types that would cause
`:AerialOpen` in an ignored window to potentially open a second aerial
win.
@Zeioth
Copy link
Author

Zeioth commented May 8, 2024

@stevearc I've tested the latest commit and all looks good thank you so much. I'm closing the issue too.

@Zeioth Zeioth closed this as completed May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant