Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One filter test (formatfiltertest07) fails on i586 #85

Open
lbeltrame opened this issue Nov 13, 2022 · 0 comments · May be fixed by #86
Open

One filter test (formatfiltertest07) fails on i586 #85

lbeltrame opened this issue Nov 13, 2022 · 0 comments · May be fixed by #86

Comments

@lbeltrame
Copy link

As the subject says, formatfiltertest07 fails for some reason on i586:

[  131s] QWARN  : TestFilters::testStringFilters(filter-filesizeformat07) Failed to convert input file size into floating point value.
[  131s] FAIL!  : TestFilters::testStringFilters(filter-filesizeformat07) Compared values are not the same
[  131s]    Actual   (result): "999 bytes 1.00 KB 10.00 KB 1000.00 KB 1.00 MB 50.00 MB 1000.00 MB 1.00 GB 1.00 TB 1.00 PB 2.00 EB 1.00 ZB 1000.00 ZB 2000.00 YB 0 bytes 0 bytes -100 bytes -50.00 MB"
[  131s]    Expected (output): "999 bytes 1.00 KB 10.00 KB 1000.00 KB 1.00 MB 50.00 MB 1000.00 MB 1.00 GB 1.00 TB 1.00 PB 2.00 EB 1.00 ZB 1.00 YB 2000.00 YB 0 bytes 0 bytes -100 bytes -50.00 MB"
Vogtinator added a commit to Vogtinator/grantlee that referenced this issue Nov 13, 2022
@Vogtinator
Fix formatting of some larger file sizes on 32bit x86
13094b7 
With the x87 FPU available, GCC uses long double precision for some variables.
Due to the function call passing a double, some comparisons break down.
That resulted in "1.00 YB" being printed as "1000.00 ZB" instead.

Fixes steveire#85
@Vogtinator Vogtinator linked a pull request Nov 13, 2022 that will close this issue
Open
Vogtinator added a commit to Vogtinator/grantlee that referenced this issue Nov 13, 2022
@Vogtinator
Fix formatting of some larger file sizes on 32bit x86
7e34ffa 
With the x87 FPU available, GCC uses long double precision for some variables.
Due to the function call passing a double, some comparisons break down.
That resulted in "1.00 YB" being printed as "1000.00 ZB" instead.

Fixes steveire#85
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Nov 16, 2022
@bmwiedemann
Update grantlee5 to version 5.3.1 / rev 9 via SR 1035528
6d0eedc 
https://build.opensuse.org/request/show/1035528
by user cgiboudeaux + dimstar_suse
- Update to 5.3.1
  * Use C++11 nullptr where appropriate
  * Use QRandomGenerator instead of deprecated qRand
  * Increase compatibility with Qt 6 APIs
  * Add CMake option to build with Qt 6 - GRANTLEE_BUILD_WITH_QT6
  * Support enum introspection on Q_GADGET
  * filesizeformat implementation as well as localized filesize
  * Make enums comparable with more operations
  * Add "truncatechars" filter
  * Fix concatenation of string lists
- Refreshed patches:
  * includes.diff
  * grantlee-5.2.0-fix-ctest-ld-library-path.patch
- Add patch to fix tests on i586 (gh#steveire/grantlee#85):
  * fix-i586-precision.patch
- Add keyring for GPG source verification

- Require cmake(Qt5LinguistTools) for building to enable testing of
- update to version 0.1.3
mbakke pushed a commit to guix-mirror/guix that referenced this issue Aug 8, 2023
gnu: grantlee: Fix build on i686-linux.
55f3b17 
This fixes a test (formatfiltertest07) failure on i686-linux.
See also <steveire/grantlee#85>.

* gnu/packages/patches/grantlee-fix-i586-precision.patch: New file.
* gnu/local.mk (dist_patch_DATA): Register it.
* gnu/packages/qt.scm (grantlee)[source]: Add patch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix formatting of some larger file sizes on 32bit x86 Vogtinator/grantlee
1 participant
@lbeltrame