-
Notifications
You must be signed in to change notification settings - Fork 10
WIP: refactor: use git-fs-repo instead of git cli #6
WIP: refactor: use git-fs-repo instead of git cli #6
Conversation
* introduces [git-fs-repo](https://github.com/chrisdickinson/git-fs-repo) * removes reliance on `git cli` * replaces regex parsing of `git log` with iteration over [^/refs/tags/*] * retains sorting of results of previous versions I had some issues with the current RegExp technique skipping some git tags in one of my projects. I am still investigating this and a second, short-term mergeable PR will land tomorrow. While dabbling around with js-only git implementations the current PR came into being. This is meant as basis for discussion about a move to a js-only conventional-changelog. fixes conventional-changelog-archived-repos#1 depends on chrisdickinson/git-load-refs#3
Thanks for the PR!
What exactly is the issue? |
@stevemao added JSDoc and inline comments for everything. I'll open a distinct PR for the RegExp issues, stay tuned. The failing coverage threshold is caused by uncovered callback error handling branches. Any ideas? |
anything I need to do before you can take another look on this? |
Holding back for now, as I am investigating some stability issues related to |
Dropping this as I don't have time to go forward on making the js-only implementation reliable |
No need to close a issue if you don't have time. Anyone who's interested can pick this up |
I might be able to pick this up since I'm interested in it. I'll give it a whirl this weekend and try to have an update. |
@stevemao unfortunately I didn't have much time - but I did get the branch rebased just fine and all the tests pass. Want me to make the PR? I didn't pick up enough context in the few minutes I looked at it so I can't say for sure that it's ready to merge. |
Sure, thanks for the contribution :) |
@stevemao @JaKXz @marionebl should we consider opening this issue up on the new monorepo? |
We're closing this pull request out as this repository has been merged into our If you would like to see this change incorporated into |
git cli
git log
with iteration over [^/refs/tags/*]git gc
git-walk-refs
I had some issues with the current RegExp technique skipping some git
tags in one of my projects.
I am still investigating this and a second, short-term mergeable PR will land tomorrow.
While dabbling around with js-only git implementations the current PR came into being. This is
meant as basis for discussion about a move to a js-only conventional-changelog.