Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): use windows path separator and cmd-shim #3

Merged
merged 2 commits into from
Jun 21, 2016

Conversation

Tapppi
Copy link
Collaborator

@Tapppi Tapppi commented Jun 18, 2016

Fix running on windows by:

  • using the semicolon path separator when on windows
  • using the cmd-shim package for creating bootstrap scripts for the executable

cmd-shim is the same package npm uses to link dependency scripts.
There is the slight difference that we need to store the executable
a mock file extension to allow cmd-shim's cygwin bootstrap script to work.

fixes #2

Fix running on windows by using windows specific path separator ';'
and the cmd-shim package for actually running the node script.
@Tapppi
Copy link
Collaborator Author

Tapppi commented Jun 20, 2016

@stevemao Added appveyor CI config to this. https://ci.appveyor.com.

@Tapppi Tapppi mentioned this pull request Jun 20, 2016
@stevemao
Copy link
Owner

@bcoe @nexdrew can you guys have a look at this please?
@Tapppi I have enabled appveyor for both mock-git and mock-bin. I don't know if you do a force commit, it will trigger the build for this PR.

Thanks 😃

@Tapppi
Copy link
Collaborator Author

Tapppi commented Jun 20, 2016

@stevemao seems to be working alright 👍

@stevemao
Copy link
Owner

I think this should be good. merging.

@stevemao stevemao merged commit c8b5ea1 into stevemao:master Jun 21, 2016
@Tapppi Tapppi deleted the 2_cmd_shim branch June 21, 2016 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows support
2 participants