Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep slash-command fixed in screen when scrolling window #377

Conversation

EnriqueSantos-dev
Copy link
Contributor

Context

In the moment when the window is scrolling, the slash command disappears and users cannot take any action. The demo below shows the problem. I believe that keeping the slash command fixed in the window is better for accessibility and improves UX.

Changes:

  • add the stick plugin when creating the slash command instance with the tippy.js lib

Demo illustrating the issue (it's is not exactly a issue, btw):

issue.mp4

Demo with solution:

fixed.mp4

Copy link

vercel bot commented Apr 10, 2024

@EnriqueSantos-dev is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@andrewdoro
Copy link
Collaborator

Hey I don't find this as a particular issue. If we look at Notion's Editor they don't keep the bubble menu sticky (at least on most of the page). If you need this behaviour please open a new issue and then we can make some adjustements to props passed for the slash-command extension.

@andrewdoro andrewdoro closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants