-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playwright tests #93
Conversation
@jaril is attempting to deploy a commit to the Elegance Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 🎉
@steven-tey mind authorizing the deploy?? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@jaril done! sorry for delay 😅 |
All green! Anything else blocking a merge? |
Just circling back — anything else blocking a merge here? @steven-tey |
So sorry for the delay @jaril – just reviewed this, LFGTM!! Thank you so much for the PR! 🙏 |
Here’s a loom walkthrough of the changes, but basically this PR:
I went ahead and added playwright test recordings with Replay. These recordings (example make it easier to debug test failures with time travel debugging.
The replays are currently uploaded to a novel.sh team I made, which you can join with this invite link.
Todo before merging: