Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright tests #93

Merged
merged 14 commits into from
Aug 9, 2023
Merged

Conversation

jaril
Copy link
Contributor

@jaril jaril commented Jul 12, 2023

Here’s a loom walkthrough of the changes, but basically this PR:

  1. Basic playwright tests
  2. Github Action workflow that runs them on pull requests
  3. Replay integration to produce replays of tests

I went ahead and added playwright test recordings with Replay. These recordings (example make it easier to debug test failures with time travel debugging.

The replays are currently uploaded to a novel.sh team I made, which you can join with this invite link.

Todo before merging:

  • Join the team using the invite link, create a new API key, and add it to your Secrets
  • Replace the hardcoded Replay API key

@vercel
Copy link

vercel bot commented Jul 12, 2023

@jaril is attempting to deploy a commit to the Elegance Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉

playwright.config.ts Outdated Show resolved Hide resolved
tests/editor.spec.ts Outdated Show resolved Hide resolved
.github/workflows/playwright.yml Show resolved Hide resolved
@jaril
Copy link
Contributor Author

jaril commented Jul 17, 2023

@steven-tey mind authorizing the deploy??

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
novel ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 10:47pm

@steven-tey
Copy link
Owner

@jaril done! sorry for delay 😅

@jaril
Copy link
Contributor Author

jaril commented Jul 19, 2023

All green! Anything else blocking a merge?

@jaril
Copy link
Contributor Author

jaril commented Aug 1, 2023

All green! Anything else blocking a merge?

Just circling back — anything else blocking a merge here? @steven-tey

@steven-tey
Copy link
Owner

So sorry for the delay @jaril – just reviewed this, LFGTM!! Thank you so much for the PR! 🙏

@steven-tey steven-tey merged commit fcc9dd3 into steven-tey:main Aug 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants