Various Updates and Fixes for vs2017-windows branch. #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDrozdowski
changed the title
ChrisDrozdowski
changed the title
ChrisDrozdowski
changed the title
ChrisDrozdowski
changed the title
ChrisDrozdowski
added a commit
to ChrisDrozdowski/h5cpp
that referenced
this pull request
Jul 15, 2019
Merge pull request steven-varga#20 from ChrisDrozdowski/vs2017-windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporates fix for Visual Studio 2017 reporting:
Error C4996 'strdup': The POSIX name for this item is deprecated. Instead, use the ISO C and C++ conformant name: _strdup.
Uses _MSC_VER to identify Visual Studio compiler.
Also fixes compilation errors when windows.h is included before h5cpp/all. See issue: #21
Also properly implements
_aligned_freefor_aligned_alloc.