Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax template-haskell upper bound for microlens-th #164

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

mpilgrem
Copy link
Contributor

GHC 9.6.1 ships with template-haskell-2.20.0.0.

Tested by building the library on Windows with Stack and the stack.yaml:

resolver: lts-20.15

packages:
- microlens
- microlens-contra
- microlens-ghc
- microlens-mtl
- microlens-th
- microlens-platform

extra-deps:
# template-haskell-2.20.0.0 is currently only a candidate package on Hackage
- url: https://hackage.haskell.org/package/template-haskell-2.20.0.0/candidate/template-haskell-2.20.0.0.tar.gz
- ghc-boot-th-9.6.1
- bytestring-0.11.4.0
- text-2.0.2
- binary-0.8.9.0

@fosskers fosskers merged commit 8671eb5 into stevenfontanella:master Mar 23, 2023
@fosskers
Copy link
Collaborator

Thank you!

@mpilgrem mpilgrem deleted the th-bound branch March 23, 2023 09:21
@mpilgrem
Copy link
Contributor Author

@fosskers, many thanks. Would it be possible to revise the package description for microlens-th-0.4.3.11 on Hackage, accordingly?

@stevenfontanella
Copy link
Owner

Looks like the version bump was not sufficient per #165 (I was also able to verify myself). FWIW I think your test didn't work because you used the resolver lts-20.15, which uses GHC 9.2.7. Your extra-dep for template-haskell 2.20 was likely ignored. I sent #166 to fix it and will create a new release after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants