fix: expose typings for options #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@minijus thanks for the PR. We will review and let you know the comments. |
pavankjadda
reviewed
Apr 6, 2022
|
@stevermeister I think we can merge this. I wanted to do this for a while, thankfully @minijus did it. Beauty of OSS. |
|
thank you @minijus ! @pavankjadda sorry, I'm not very active on a project now, it's difficult to focus for me on something else except news from Ukraine :( |
|
I understand, just wanted to get a quick review. I am sorry for what's going on in Ukraine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be handy just to import
CookieOptionsdirectly instead of re-typing them when usingngx-cookie-service.