Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fixes an issue with Request type #289

Merged
merged 6 commits into from
Nov 8, 2023
Merged

Conversation

pavankjadda
Copy link
Collaborator

No description provided.

This commit replaces `npm` with `pnpm` in the Github Actions workflows. `pnpm` is used due to its efficient handling of dependencies, reducing the space and installation time required. In each workflow, `actions/setup-node@v2` is updated to `actions/setup@v3`, the install command is switched to `pnpm install --frozen-lockfile` and all the npm run commands are switched to pnpm equivalents. This enhances overall workflow performance.
Switched from npm to pnpm in Github Actions. As part of this change, updated .prettierignore to ignore pnpm-lock.yaml instead of package-lock.json. This ensures that the Prettier tool ignores automatically-generated lock files created by pnpm.
@pavankjadda pavankjadda added the bug label Nov 8, 2023
@pavankjadda pavankjadda self-assigned this Nov 8, 2023
Copy link

github-actions bot commented Nov 8, 2023

Hello 👋 @pavankjadda
Thank you for raising your pull request. Please make sure you have followed our contributing guidelines. We will review it as soon as possible.

…ce.ts

Adjusted the spacing between the curly braces and the code within them to improve readability based on the team's coding style guide. It's a small change but it helps to maintain consistency throughout the codebase.
The 'Test' step within the GitHub Actions Continuous Integration (CI) workflow was commented out. The change was made due to the current tests resulting in unnecessary runtime, therefore, to optimize the performance of our CI pipeline, it was decided to temporarily disable the 'Test' step until further notice.
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pavankjadda pavankjadda merged commit e4eddf6 into master Nov 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant