Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integrator kwargs to MD #175

Merged
merged 4 commits into from
May 31, 2024
Merged

Add integrator kwargs to MD #175

merged 4 commits into from
May 31, 2024

Conversation

ElliottKasoar
Copy link
Member

@ElliottKasoar ElliottKasoar commented May 31, 2024 •
edited
Loading

Resolves #172

To do:

  • Improve CLI test. Possibly just pick a value for one of the outputs to check it doesn't change, as we can't check the mask itself is set as we do in the Python.

@ElliottKasoar ElliottKasoar added enhancement New/improved feature or request janus labels May 31, 2024
@ElliottKasoar ElliottKasoar self-assigned this May 31, 2024
@ElliottKasoar ElliottKasoar force-pushed the add-md-kwargs branch 2 times, most recently from 3768533 to 1061b7f Compare May 31, 2024 15:13
@alinelena alinelena merged commit 25a3158 into stfc:main May 31, 2024
8 checks passed
@ElliottKasoar ElliottKasoar deleted the add-md-kwargs branch June 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinelena alinelena alinelena approved these changes

@oerc0122 oerc0122 Awaiting requested review from oerc0122

Assignees

@ElliottKasoar ElliottKasoar

Labels
enhancement New/improved feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add kwargs for MD integrators
2 participants
@ElliottKasoar @alinelena