Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Windows and MacOS #214

Closed
wants to merge 4 commits into from
Closed

Conversation

ElliottKasoar
Copy link
Member

@ElliottKasoar ElliottKasoar commented Jul 15, 2024

I thought we had an issue, but can't find it...

  • Adds Windows and MacOS (arm and intel, I think, based on this list)

These are experimental, as we can't currently guarantee support/functionality, but this makes it easier to see and fix issues, and hopefully we can get to a point where they are all supported fully.

Currently there seem to be at least a couple that we could address soon:

  • Installing dgl for windows
  • Setting the correct device for chgnet (on MacOS or any OS?)

(I don't suggest fixing them as part of this PR)

Unfortunately I think even "allowed" failures lose the green tick, which is annoying.

@ElliottKasoar ElliottKasoar added enhancement New/improved feature or request janus labels Jul 15, 2024
@ElliottKasoar ElliottKasoar self-assigned this Jul 15, 2024
@ElliottKasoar
Copy link
Member Author

ElliottKasoar commented Jul 26, 2024

Errors on latest MacOS should hopefully be fixed in the next CHGNet release (CederGroupHub/chgnet#181).

Assuming we want to test it, we probably want to use self-hosted runners for Intel Mac (and maybe others), since it times out.

@ElliottKasoar
Copy link
Member Author

The Windows issue seems to be due to the availability of built distributions on PyPI. The most recent releases are:

2.2.1, which only seems to include Windows built distributions
2.2.0, which only seems to include MacOS built distributions
2.1.0, which only seems to include linux and MacOS
2.0.0, seems to include built distributions for Windows, MacOS and linux

So a potential solution to ensure compatibility might be reverting to 2.0.0.

Alternatives include:

  • Follow their suggested installation, but this requires specifying the torch version, and will not work Winows/MacOS after 2.2.1:

    • pip install dgl -f https://data.dgl.ai/wheels/torch-2.1/repo.html
  • Install from source, which requires different instructions for each OS

@ElliottKasoar
Copy link
Member Author

These will be tested on self-hosted runners e.g. via #334.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New/improved feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants