Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
We may want to wait to see how @federicazanca has implemented tox for aiida-mlip, but this seems to work as expected e.g. using
tox run -e ALL
.To address the questions in stfc/aiida-mlip#59, I think the default
tox run
will only run the pytest section with Python 3.10, but, using-e
, all tests, including the range of Python versions listed, can be tested individually/together.Note: with the current set up (
poetry install --no-root --sync
)There are a couple of alternatives, including allowing tox to install everything, or running
poetry install --with dev
etc. withskip_install = true
, in which case:(See https://python-poetry.org/docs/faq#is-tox-supported)
This might be worth looking into this more in aiida-mlip @federicazanca, as we have more dependencies already set up to test.
Also note we already have
in pyproject.toml, so tox is able to build the package using poetry as expected, and
isolated_build
is now always used, so this does not need to be added.