Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planet available points initialization #10

Closed
kirirur opened this issue Nov 22, 2014 · 7 comments
Closed

Planet available points initialization #10

kirirur opened this issue Nov 22, 2014 · 7 comments
Assignees
Labels
Milestone

Comments

@kirirur
Copy link
Contributor

kirirur commented Nov 22, 2014

There's a bug in create_planet() function when constant USER_START_BOOST is set to 0. The normal planet being created does not get planet_available_points field initialized correctly so it remain to its default value that it's zero. With this value set, no buildings can be build.

@kirirur kirirur added the bug label Nov 22, 2014
@kirirur kirirur self-assigned this Nov 22, 2014
@kirirur kirirur added this to the Version 1.3 milestone Nov 22, 2014
kirirur added a commit that referenced this issue Nov 22, 2014
@Caberhagen
Copy link
Contributor

I tried your fix. Removed planets and execute populate world. Now we have
an php error. Undefined variable max points.
Am 22.11.2014 11:16 schrieb "Andrea Carolfi" notifications@github.com:

There's a bug in create_planet() function when costant USER_START_BOOST is
set to 0. The normal planet being created does not get
planet_available_points initialized correctly so it remain to its default
value that it's zero. With this value set, no buildings can be build.


Reply to this email directly or view it on GitHub
#10.

@kirirur
Copy link
Contributor Author

kirirur commented Nov 24, 2014

Hi,

I've found the problem: I thought global variable $MAX_POINTS was visible in the whole create_world function instead only if USER_START_BOOST has scope on it, I'll change the if/else.

kirirur added a commit that referenced this issue Nov 24, 2014
Declaration of global variable $MAX_POINTS was missing in else
statement.
@kirirur
Copy link
Contributor Author

kirirur commented Nov 24, 2014

Should be finally ok now. Let me know if we can close this.

@Caberhagen
Copy link
Contributor

I am on work now. I try it at home. Feedback follow...

@Caberhagen
Copy link
Contributor

You are great. now it works fine.
User creation and pop_worlds testet and working.

@Kail72
Copy link
Contributor

Kail72 commented Nov 24, 2014

Are you two having fun? ^_^

2014-11-24 16:23 GMT+01:00 Caberhagen notifications@github.com:

You are great. now it works fine.
User creation and pop_worlds testet and working.


Reply to this email directly or view it on GitHub
#10 (comment).

@kirirur
Copy link
Contributor Author

kirirur commented Nov 25, 2014

Well yeah, we've found and fixed a couple of bugs! :)

Any news from you?

@kirirur kirirur closed this as completed Nov 25, 2014
Caberhagen added a commit that referenced this issue Sep 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants