-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package lock to match 0.16.4 release #208
Conversation
Update package-lock.json which is not aligned with package.json
Windows build failed due to an HTTP error:
|
I think this mismatch might be the reason why the last version doesn't compile using node2nix. Though a new version of node2nix will have a workaround for this issue. |
@turboMaCk This I see that there is a version mismatch on the project version in the lock file, but there are additional changes in you PR ( |
@stil4m I've tried to rerun this with We don't care that much in nix as the newer version of node2nix has a workaround for situations like this (even though I'm yet to test it on this case). If you wish to fix it in another way feel free to close this PR but as far as I can tell this is the right format for node 8 and current state of master. |
thanks @stil4m btw I can confirm that latest version of node2nix has no issue with latest release NixOS/nixpkgs#64486 |
@turboMaCk Thanks. I've just restricted the nvmrc even more (to include a minor and a patch). This may be the difference I've seen on my machine and the PR you've created. Great to hear that there are no issues. I'm not sure if it is possible, but could we add a CI check with |
@stil4m if you would like to have something like this I can try to investigate possible solution. The main concern is about build times though. I'm not sure if it won't slow the ci too much which might be quite annoying for you and other contributors. In some sense it's the job of node2nix project to be compatible with npm and node. This PR was just chore I run into while debugging. I think the correct solution to any node2nix build error is likely bugfix in node2nix rather than in this or any other package. Think about it and let me know if you're still interested in having it in CI pipeline. |
Update package-lock.json which is not aligned with package.json