New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start when the DOM is interactive #131

Merged
merged 7 commits into from Mar 27, 2018

Conversation

Projects
None yet
2 participants
@javan
Contributor

javan commented Mar 22, 2018

Alternate title: Defer connecting controllers until the DOM is ready.

Fixes #97

@javan javan added this to the 1.1 milestone Mar 22, 2018

@david-a-wheeler

This comment has been minimized.

david-a-wheeler commented Mar 22, 2018

Does this PR work with turbolinks? Turbolinks rewrites pages, so its idea of "ready" is different than many other systems.

@javan javan changed the title from Start element observers when the DOM is interactive to Start when the DOM is interactive Mar 23, 2018

@javan javan merged commit 6b15e02 into master Mar 27, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@javan javan deleted the async-start branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment