Add instrumentation #167
Merged
Add instrumentation #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for this thorough implementation, it looks very interesting! I'll dive into it later this weekend |
|
Released in 1.3.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Feature
Description
Add a new configuration option
Futurism.instrumentation.When enabled, ActiveSupport notification event
render.futurismis emitted on render calls.Additionally, delay the initialization of the logger until the Rails application's logger is initialized and enhance the handling of configuration options to handle blank ENV values.
Why should this be added
This is useful for performance monitoring, specifically for tracking the source of
futurizecalls.Checklist