@stitches/stringify #477
Merged
@stitches/stringify #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 174fa57:
|
jonathantneal
force-pushed
the
jn.stringify
branch
5 times, most recently
from
83c460e
to
2615826
Compare
arempe93
reviewed
Mar 13, 2021
jonathantneal
force-pushed
the
jn.stringify
branch
from
d15ebc3
to
82249ed
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
This PR would provide the
stringifyfunction from Stitches as its own package —@stitches/stringify.What is the
@stitches/stringifypackage?Stringify converts a JavaScript object to a CSS string, optionally replacing values if a replacer function is specified.
This function is a mirror of the
JSON.stringifyfunction, only instead for generating CSS.Why a
@stitches/stringifypackage?Stitches includes a very small, highly effective, performant CSS serializer capable of producing nearly-if-not-all forms of CSS. Unfortunately, the browser does not provide such functionality, and there is no other package yet that can stringify JavaScript objects into this many forms of CSS, and not while also downsampling complex nesting with a high level of accuracy. As a package that does all of this in under 1kB, such functionality may be useful to more developers and in more situations than Stitches can intend to provide. This may include runtime-specific CSS libraries, CSSOM enhancements, Node serializers, packaged components, etc.
Therefore, separating this package may provide us an opportunity to strengthen a core component within stitches while also helping move the web forward in many new ways.