Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Renames columns to outputs in driver & ResultMixin build_result function #61

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Feb 6, 2022

The framework is generic, not only for tabular things. So removing
this language to not box people in.

Changes

  • changes use of columns to outputs in result mixin build_result().
  • changes use of columns to outputs in driver code.

Testing

  1. Unit testing FTW.

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the TODO link to standards
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python

  • python 3.6
  • python 3.7

Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix conflicts but it looks good

The framework is generic, not only for tabular things. So removing
this language to not box people in.
We weren't passing through inputs like execute() now takes.
@skrawcz skrawcz merged commit 8a08a5e into main Feb 6, 2022
@skrawcz skrawcz deleted the rename_columns_to_outputs branch February 6, 2022 23:01
gitbook-com bot pushed a commit that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants