This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Lazy config evaluation #64
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more generic, and allows us to support lazily evaluated configurations if needed.
elijahbenizzy
force-pushed
the
lazy-config-evaluation
branch
from
df8b901
to
1165b9c
Compare
|
Need to add tests/figure out what to test. Hopefully this demonstrates the issue. IMO chainmap is actually better here -- supporting a lazyconfig is reasonable. That said, I'd prefer the simplicity with a dictionary. |
|
Pros of this:
Cons of this:
|
skrawcz
reviewed
Feb 7, 2022
Comment on lines
+316
to
+317
| computed: Mapping[str, Any] = None, | ||
| overrides: Mapping[str, Any] = None): |
There was a problem hiding this comment.
No, but I figured it would be nice to stay consistent.
skrawcz
reviewed
Feb 7, 2022
| @@ -379,7 +380,7 @@ def combine_config_and_inputs(config: Dict[str, Any], inputs: Dict[str, Any]) -> | |||
| duplicated_inputs = [key for key in inputs if key in config] | |||
| if len(duplicated_inputs) > 0: | |||
| raise ValueError(f'The following inputs are present in both config and inputs. They must be mutually disjoint. {duplicated_inputs}') | |||
| return {**config, **inputs} | |||
| return collections.ChainMap(config, inputs) | |||
There was a problem hiding this comment.
does the unit test need to change to enforce chain map's way of not evaluating things?
There was a problem hiding this comment.
Yeah, if the contract is that we don't evaluate the driver then we want to test that its not evaluated. That said, I don't really like that as a contract, and it feels limiting later on, so let's think through.
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Short description explaining the high-level reason for the pull request]
Additions
Removals
Changes
Testing
Screenshots
If applicable
Notes
Todos
Checklist
Testing checklist
Python