Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change Group concept to Tags #37

Merged
merged 16 commits into from
May 19, 2024
Merged

feat: change Group concept to Tags #37

merged 16 commits into from
May 19, 2024

Conversation

a-frantz
Copy link
Member

@a-frantz a-frantz commented May 14, 2024

Describe the problem or feature in addition to a link to the issues.

Currently, each lint rule has a singular Group associated with it. This PR changes those groups into one or more Tags.

Before submitting this PR, please make sure:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have updated the README or other documentation to account for these
    changes (when appropriate).
  • You have added an entry to the relevant CHANGELOG.md (see
    "keep a changelog" for more information).
  • Your commit messages follow the conventional commit style.
  • Your changes are squashed into a single commit (unless there is a really
    good, articulated reason as to why there shouldn be more than one).

@a-frantz a-frantz added the enhancement New feature or request label May 14, 2024
@a-frantz a-frantz self-assigned this May 14, 2024
@a-frantz a-frantz marked this pull request as ready for review May 14, 2024 17:51
Copy link
Collaborator

@peterhuene peterhuene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me; just the minor comments!

wdl-core/src/concern/lint/tag_set.rs Show resolved Hide resolved
wdl-core/src/concern/lint/tag_set.rs Outdated Show resolved Hide resolved
Co-authored-by: Peter Huene <peter@huene.dev>
@a-frantz a-frantz merged commit bd265d3 into main May 19, 2024
5 of 6 checks passed
@a-frantz a-frantz deleted the feat/group-to-tags branch May 19, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants