Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use wdl-format on everything #165

Closed
wants to merge 3 commits into from
Closed

feat: use wdl-format on everything #165

wants to merge 3 commits into from

Conversation

a-frantz
Copy link
Member

No description provided.

@a-frantz a-frantz self-assigned this Jul 14, 2024
import "https://raw.githubusercontent.com/stjude/seaseq/3.0/workflows/tasks/samtools.wdl" as seaseq_samtools
import "https://raw.githubusercontent.com/stjude/seaseq/3.0/workflows/tasks/seaseq_util.wdl" as seaseq_util
import "../general/bam-to-fastqs.wdl"
as b2fq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely do not like this behavior. In my mind, imports should take one line irrespective of how long the line it (at least right now while URLs are the primary thing being imported).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking each clause onto it's own line was a bit of an experiment. If you feel strongly I have no problem changing this behavior.

Copy link
Member

@claymcleod claymcleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else I skimmed looked really good!

@a-frantz a-frantz closed this Jul 24, 2024
@a-frantz a-frantz deleted the formatted branch July 24, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants