-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embedded hal traits #59
Conversation
Wondering what's blocking this? |
Would be nice to have this |
@adamgreig could you please take a look at this? |
Thanks for the quick response @adamgreig but that's not quite what I meant 😅 @jonas-schievink seems to no longer be maintaining this crate and I was hoping you could either get this merged and released or facilitate someone else doing so. |
Yep, can do. I had hoped to have a clean merge button after reviewing but I'm not technically on the team for it 😅 Is anyone interested in helping to maintain this crate? I can get this merged and do a release (though probably not for a day or two, I'm travelling atm) but more usefully if anyone is interested I can get you set up. |
Awesome, thank you! I wouldn't mind helping out :) |
This is now released at 0.8. Thanks for offering to help! I don't have time to set it up right now but will try and get it sorted in the next few days. Ping me if you get bored of waiting! |
This PR updates the
embedded-hal
dependency and switches to its replacementembedded-can
. This means that nowsocketcan
andbxcan
share a common trait in theembedded-can
library, which me really would like.