Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update embedded hal traits #59

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

T-Bakker
Copy link
Contributor

This PR updates the embedded-hal dependency and switches to its replacement embedded-can. This means that now socketcan and bxcan share a common trait in the embedded-can library, which me really would like.

@tristanguerragomez
Copy link

Wondering what's blocking this?

@dimpolo
Copy link

dimpolo commented Apr 15, 2024

Would be nice to have this

@dimpolo
Copy link

dimpolo commented Sep 13, 2024

@adamgreig could you please take a look at this?

@dimpolo
Copy link

dimpolo commented Sep 13, 2024

Thanks for the quick response @adamgreig but that's not quite what I meant 😅

@jonas-schievink seems to no longer be maintaining this crate and I was hoping you could either get this merged and released or facilitate someone else doing so.

@adamgreig
Copy link
Member

Yep, can do. I had hoped to have a clean merge button after reviewing but I'm not technically on the team for it 😅

Is anyone interested in helping to maintain this crate? I can get this merged and do a release (though probably not for a day or two, I'm travelling atm) but more usefully if anyone is interested I can get you set up.

@dimpolo
Copy link

dimpolo commented Sep 16, 2024

Awesome, thank you!

I wouldn't mind helping out :)

@adamgreig adamgreig merged commit eeb2244 into stm32-rs:master Sep 17, 2024
10 checks passed
@adamgreig
Copy link
Member

This is now released at 0.8. Thanks for offering to help! I don't have time to set it up right now but will try and get it sorted in the next few days. Ping me if you get bored of waiting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants