Add ieee802_3_miim crate for MIIM support, and allow MAC to borrow or own Mii
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datdenkikniet
force-pushed
the
more_smi
branch
3 times, most recently
from
273b56d
to
62db215
Compare
datdenkikniet
changed the title
StationManagement trait, and allow MAC to ignore, borrow, or own SMIStationManagement trait, and allow MAC to borrow or own SMI
datdenkikniet
force-pushed
the
more_smi
branch
5 times, most recently
from
8c7e37d
to
85be644
Compare
datdenkikniet
force-pushed
the
more_smi
branch
2 times, most recently
from
2244066
to
3929610
Compare
datdenkikniet
changed the title
StationManagement trait, and allow MAC to borrow or own SMIieee802_3_miim crate for MIIM support, and allow MAC to borrow or own SMI
Re-add StationManagement trait Implement StationManagement for `Smi` and `EthernetMAC<OwnedSmi>` Add basic driver for `LAN87XXA` based phys, based on `StationManagement` trait
Add some docs and make LAN87XXA phy implmementation a bit more clear
Make `mac` a bit more encapsulated to avoid polluting `lib` scope
…T PHY will be supported
Remove type state and just have another type for owned SMI
datdenkikniet
force-pushed
the
more_smi
branch
2 times, most recently
from
4dc3dac
to
34b8581
Compare
…cess to the entirety of the MAC peripheral for the duration of SMI accesses
datdenkikniet
changed the title
ieee802_3_miim crate for MIIM support, and allow MAC to borrow or own SMIieee802_3_miim crate for MIIM support, and allow MAC to borrow or own Mii
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of "forcing" users to implement their own PHYs based on
Smi, and keeping track of Mdio/Mdc pins manually, this API allows one to choose between the different ways of obtaining control over the MAC's SMI.I've removed the
smifeature because it makes little sense to me to have one to begin with, as most users will always want to interact with SMI, and if not they can continue usingnewto avoid it.We start using the
ieee802_3_miimcrate (authored by me) for Miim (previously: StationManagement) and PHY configuration support.Additionally, this PR splits up the code for the MAC and DMA into seperate modules for easier oversight.