Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CAN peripherals with the bxcan crate #293

Merged
merged 7 commits into from
Feb 16, 2021
Merged

Support for CAN peripherals with the bxcan crate #293

merged 7 commits into from
Feb 16, 2021

Conversation

timokroeger
Copy link
Contributor

Replaces #215

@jonas-schievink refactored the previous PR into a device agnostic driver crate.
Use the new crate to minimize fragmentation between stm32fxxx-hal crates.

Draft until I have upstreamed a last missing improvement to masked filters.

@timokroeger timokroeger changed the title Support for CAN peripherals with the bxcan crate [WIP] Support for CAN peripherals with the bxcan crate Dec 8, 2020
@timokroeger timokroeger mentioned this pull request Dec 8, 2020
Closed
4 tasks
@timokroeger timokroeger marked this pull request as draft December 8, 2020 07:30
@Sh3Rm4n Sh3Rm4n mentioned this pull request Dec 9, 2020
Open
12 tasks
@santiagoalvarez santiagoalvarez mentioned this pull request Dec 26, 2020
Closed
@arrowcircle
Copy link

Any news?

@timokroeger timokroeger marked this pull request as ready for review December 28, 2020 15:01
@timokroeger timokroeger changed the title [WIP] Support for CAN peripherals with the bxcan crate Support for CAN peripherals with the bxcan crate Dec 28, 2020
TheZoq2
TheZoq2 reviewed Jan 23, 2021
View reviewed changes
Copy link
Member

@TheZoq2 TheZoq2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally found the time to review this, thanks for all the effort you've put into this.

The changes look good, there are a few compiler warnings and a missing changelog entry, but other than that, it looks ready to merge!

examples/can-echo.rs Outdated Show resolved Hide resolved
examples/can-rtic.rs Outdated Show resolved Hide resolved
src/can.rs Show resolved Hide resolved
@jonas-schievink
Copy link

bxcan 0.4.0 has been released, you might want to update to that before merging

@arrowcircle
Copy link

Any news?

@TheZoq2
Copy link
Member

TheZoq2 commented Feb 16, 2021

Finally got around to looking at this, sorry about the delay!

Everything looks great, thanks everyone who has helped out getting this working 😍

@TheZoq2 TheZoq2 merged commit 0f367e6 into stm32-rs:master Feb 16, 2021
@arrowcircle
Copy link

Thanks for the work! Any plans on release date for can support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheZoq2 TheZoq2 TheZoq2 left review comments

@jonas-schievink jonas-schievink jonas-schievink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timokroeger @arrowcircle @jonas-schievink @TheZoq2