-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Dma #55
Restore Dma #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
Would you mind making two changes?
- replace
extern crate panic_halt;
byuse panic_halt as _;
- add the new feature (and the version bump) to the CHANGELOG.md.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @burrbull!
Cargo.toml
Outdated
stm32f1 = "0.6.0" | ||
cortex-m-rt = "0.6.8" | ||
#stm32f1 = "0.7.0" | ||
stm32f1 = {path = "/home/burrbull/stm32-rs/stm32f1"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A local path slipped in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, this is an accident.
examples/adc.rs
Outdated
@@ -1,26 +1,23 @@ | |||
#![deny(unsafe_code)] | |||
#![deny(warnings)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discovered not long ago that this is an anti-pattern. See here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I will remove this from other examples.
The next three days I will not be able to commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.