Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Dma #55

Merged
merged 5 commits into from
Apr 25, 2019
Merged

Restore Dma #55

merged 5 commits into from
Apr 25, 2019

Conversation

burrbull
Copy link
Member

No description provided.

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Would you mind making two changes?

  • replace extern crate panic_halt; by use panic_halt as _;
  • add the new feature (and the version bump) to the CHANGELOG.md.

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @burrbull!

Cargo.toml Outdated
stm32f1 = "0.6.0"
cortex-m-rt = "0.6.8"
#stm32f1 = "0.7.0"
stm32f1 = {path = "/home/burrbull/stm32-rs/stm32f1"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A local path slipped in here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this is an accident.

examples/adc.rs Outdated
@@ -1,26 +1,23 @@
#![deny(unsafe_code)]
#![deny(warnings)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I discovered not long ago that this is an anti-pattern. See here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I will remove this from other examples.

@burrbull
Copy link
Member Author

The next three days I will not be able to commit.
Therefore, if minor fixes are needed, please correct them yourself or wait for me.

Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@therealprof therealprof merged commit 66cfb78 into stm32-rs:master Apr 25, 2019
@burrbull burrbull deleted the restoredma branch April 28, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants