Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added stm32f302x6, stm32f302x8 #132

Merged
merged 2 commits into from
Aug 30, 2020
Merged

added stm32f302x6, stm32f302x8 #132

merged 2 commits into from
Aug 30, 2020

Conversation

sprhawk
Copy link
Contributor

@sprhawk sprhawk commented Aug 28, 2020

No description provided.

@teskje
Copy link
Collaborator

teskje commented Aug 28, 2020

This has also been done in #129, but I suppose it will still take some time until that gets merged, so I'm fine with merging this in the meantime.

I'm curious, have you tested the crate with one of these boards?

@sprhawk
Copy link
Contributor Author

sprhawk commented Aug 28, 2020

@ra-kete Yes, I'm running it on an stm32f302r8

Copy link
Collaborator

@teskje teskje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry too?
LGTM otherwise.

@sprhawk
Copy link
Contributor Author

sprhawk commented Aug 29, 2020

@ra-kete How to write content of Changelog?

Like this?

### Added                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        
- added stm32f302x6, stm32f302x8 ([#132](https://github.com/stm32-rs/stm32f3xx-hal/pull/132))                                                                                                                                                                                                                           

@teskje
Copy link
Collaborator

teskje commented Aug 29, 2020

Yes, just put it under the existing Added entries under the Unreleased version.
For wording you look at what's there for adding support for new devices in older versions. Something like "Support for stm32f302x6 and stm32f302x8 devices".

@sprhawk
Copy link
Contributor Author

sprhawk commented Aug 30, 2020

@ra-kete added to changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants