Rtc v2 #136
Merged
Rtc v2 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teskje
requested changes
Sep 4, 2020
|
All reviews addressed. |
teskje
requested changes
Sep 8, 2020
|
@David-OConnor , thank you for getting around to cleaning up and improving the code! |
teskje
approved these changes
Sep 8, 2020
|
LGTM. Can you add a changelog entry too? Sorry, forgot about that before. |
|
Done. @smedellin90 : Thanks for making this. I've been relying on it for months! |
Closed
sprhawk
pushed a commit
to sprhawk/stm32f3xx-hal
that referenced
this pull request
Sep 10, 2020
Add support for the onboard real-time clock (RTC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #93, by @smedellin90
Has most of the review changes implemented, but is missing the unsafe justifications; I'm not sure how to do them.