Update stm32f3 to v0.11.0 #97
Conversation
Cargo.toml
Outdated
| @@ -23,7 +23,7 @@ cortex-m = "0.6" | |||
| cortex-m-rt = "0.6" | |||
| embedded-hal = "0.2" | |||
| nb = "0.1" | |||
| stm32f3 = "0.10" | |||
| stm32f3 = "0.11.0" | |||
There was a problem hiding this comment.
sure we don't want to go for the more general "0.11"?
Aus of the Changelog they seem to go from 0.n.0 to 0.n+1.0 quite reliabely so incoperating a sub-sub version might allow for a seamless bugfix.
There was a problem hiding this comment.
For consistency, I should use "0.11". Thanks for pointing this out :)
Cargo's version always translates to the "^0.11.0" semver version number, unless stated otherwise. So it should not make a difference, as 0.11.1 would automatically be pulled in, when such a version would be released.
| acr.acr().modify(|_, w| { | ||
| if hclk <= 24_000_000 { | ||
| w.latency().ws0() | ||
| } else if hclk <= 48_000_000 { | ||
| w.latency().ws1() |
There was a problem hiding this comment.
All those magic numbers make me nervous.
I'm not sure if it helps that they are documented but not explained in stm32f3
There was a problem hiding this comment.
Yeah, the documentation of the stm32f3 is always very brief. But more detailed explanation is not the intent of the stm32f3 crate, as this is auto-generated code from svd files. A more detailed explanation is always in the reference manual. However, it does not hurt to add documentation here, to explain, why this is needed.
Remove now unneeded unsafe from the flash state configuration in
src/rcc.rsand useHCLKinstead ofSYSCLKas the reference manual suggests.