Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conversions from us/ns to Hertz #136

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Sep 22, 2020

No description provided.

Copy link
Member

@hargoniX hargoniX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although every HAL adding their own src/timer.rs which provides a U32Ext trait seems kinda dumb...we should definitely be able to do better than this, but I guess that might be a change we can do another time;

@mattico
Copy link
Contributor Author

mattico commented Sep 23, 2020

There's the embedded-time crate which is being integrated into rtic maybe. We could use it as well.

@mattico mattico mentioned this pull request Sep 23, 2020
@richardeoin
Copy link
Member

+1 on looking into the embedded-time crate. But for now this PR is useful on its own.

bors r+

@bors bors bot merged commit 418971b into stm32-rs:master Sep 24, 2020
@mattico mattico deleted the add-us-ns-hz branch September 24, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants