Wire: Max TX buffer length #1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
txBufferIndex and txBufferLength always have the same value. Thus only 1 variable is necessary. Rename it txDataSize for better understanding. Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Prepare introduction of max TX buffer length Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
WIRE_MAX_TX_BUFF_LENGTH
branch
from
f7c0ce6
to
8f995c5
Compare
fpistm
requested changes
Nov 26, 2021
If data size to be sent is greater than the max defined, application can split the transfert Note: no limit implemented in RX buffer, because when receiving, data are received on I2C, it is not possible to split. Fixes stm32duino#1539 Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
Check of null pointer is already done in both * allocateTxBuffer() * allocateRxBuffer() and it leads to _Error_Handler() Signed-off-by: Alexandre Bourdiol <alexandre.bourdiol@st.com>
ABOSTM
force-pushed
the
WIRE_MAX_TX_BUFF_LENGTH
branch
from
8f995c5
to
2e73fd2
Compare
fpistm
approved these changes
Nov 26, 2021
STM32 core based on ST HAL
automation
moved this from Needs review
to Reviewer approved
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wire: limit TX buffer size to avoid consuming too much stack
If data size to be sent is greater than the max defined,
application can split the transfert
Note: no limit implemented in RX buffer, because when receiving,
data are received on I2C, it is not possible to split.
Fixes #1539